Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## uif/cl-1430/tree-extraction #24840 +/- ##
===============================================================
+ Coverage 63.22% 63.24% +0.01%
===============================================================
Files 5000 5000
Lines 162594 162616 +22
Branches 26225 26234 +9
===============================================================
+ Hits 102807 102851 +44
+ Misses 52805 52778 -27
- Partials 6982 6987 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
CL-1430
📔 Objective
This PR replaces CDK's
TreeKeyManagerin the multi-selectbit-filter-menutree with a custom keyboard handler that uses each row's position in the option list rather than its index. This prepares the tree for virtualization, where most rows won't be rendered.I explored keeping the CDK
TreeKeyManager, but it would require a decent amount of code to work around some limitations and bugs. It was less code and easier to follow the custom keyboard handling than to integrate with the CDK and add these workarounds:Keyboard behaviour is unchanged, with two bug fixes to existing behavior:
*(open all siblings) no longer moves focus to a different option when rows open above the focused one.