Skip to content

Pm 46678 - #24831

Closed
jprusik wants to merge 7 commits into
mainfrom
pm-46678
Closed

Pm 46678#24831
jprusik wants to merge 7 commits into
mainfrom
pm-46678

Conversation

@jprusik

@jprusik jprusik commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

📔 Objective

📸 Screenshots

let parsedSenderUrl: URL;
try {
parsedSenderUrl = new URL(senderUrl);
} catch {

@aikido-pr-checks aikido-pr-checks Bot Nov 18, 2026 •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bare catch in isHttpAuthenticationPopoutSender silently treats every parsing failure as an invalid sender URL, hiding unexpected errors.

Suggested change
} catch {
} catch (error) {
console.error("Failed to parse HTTP authentication popout sender URL:", error);
Details

✨ AI Reasoning
​The handler catches any URL parsing error and silently returns false. That prevents callers from distinguishing an invalid sender URL from other unexpected failures.

Reply on this comment to give feedback or ignore the issue.
More info

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AIKIDO-2026-21223 in rusqlite - medium severity
With the optional serialize feature, Connection::deserialize_read_exact allocates memory through SQLite before reading the input. A truncated input returns early without releasing that allocation, so repeated failures can exhaust process memory. The fix closes the read-error path without leaving the allocation outstanding.

Details

Remediation Aikido suggests bumping this package to version 0.41.0 to resolve this issue

Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Claude Code validation

Result: Pass

One Claude-material file changed: bitwarden_license/bit-web/src/app/pam/CLAUDE.md. It carries no secrets, no harness-loosening directives, and every symbol and path its new lines name resolves at head. The one finding is that the merge resolved this file to the branch's older copy, so the diff reverts PAM guidance that is already on main.

Findings
  • ⚠️ IMPORTANT: Finding 1: Merge reverts PAM guidance present on main, including the PAM-579 "never read per row" constraint (bitwarden_license/bit-web/src/app/pam/CLAUDE.md:123)

Comment on lines +123 to +125
lease is in neither. "Unavailable" matches items whose rule refuses a request right now. Each
row's state is read once per row list and shared across options (`accessKinds$`), so the
chip's counts don't multiply the reads. Add an option by appending to the list, not by

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ IMPORTANT: This hunk reverts PAM guidance that is already on main — the merge resolved this file to the branch's older copy.

Details and fix

The merge commit (2fbb05c) took the first parent's version of this file, so the pull request's diff against main removes guidance added by [PAM-577] (60eec68), not just the lines above:

  • There is no "Unavailable" option… the list views read no per-item state → replaced with per-row reads shared via accessKinds$
  • Never go back to a read per row: 32k gated rows made Chrome refuse the requests (PAM-579) → deleted outright
  • The MyAccessRequestsService / badgesFromMyRequests() paragraphs in the badge section and the AccessRefreshService rationale under "Two services drive every refresh"

The deleted PAM-579 sentence is the one that stops an agent (or a person) reintroducing a per-row read that was already measured as a browser-level failure at 32k gated rows. Losing it from CLAUDE.md removes the only in-repo record of that constraint in this scope.

This is not an isolated documentation edit: the same merge reverts the companion implementation — bit-pam-components/src/services/my-access-requests.service.ts, bit-pam/src/helpers/request-list-badges.ts, and bit-pam/src/helpers/reread-at.ts are deleted by this diff (982 deletions across the PAM subtree). Nothing in this pull request's stated subject (HTTP basic auth, pm-46678) touches PAM, so the revert reads as an unintended merge resolution rather than a decision.

Re-resolve the merge in favor of main for the PAM subtree, starting with this file:

git checkout origin/main -- bitwarden_license/bit-web/src/app/pam/CLAUDE.md \
  bitwarden_license/bit-pam bitwarden_license/bit-pam-components

Then confirm git diff origin/main... -- bitwarden_license/ shows only changes this pull request intends.

validate-ai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant