Skip to content

PM-43629-remove-password-permission - #24776

Open
bmbitwarden wants to merge 2 commits into
mainfrom
PM-43629-remove-password-button-issue
Open

bmbitwarden wants to merge 2 commits into
mainfrom
PM-43629-remove-password-button-issue

Conversation

@bmbitwarden

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-43629

📔 Objective

The remove password button is displayed when the user doesn't have permissions to remove it

📸 Screenshots

Screenshot 2026-11-15 at 8 06 37 PM Screenshot 2026-11-15 at 8 06 28 PM

@bmbitwarden
bmbitwarden requested a review from a team as a code owner November 16, 2026 01:07
@bmbitwarden bmbitwarden added needs-qa Marks a PR as requiring QA approval ai-review Request a Claude code review t:bugfix Change Type - Bugfix labels Nov 16, 2026
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This bugfix adds a sendAuthRequired$ stream to SendPolicyService, derived from the Send Controls whoCanAccess setting. That stream and the Send's disabled flag now hide the "Remove password" / "Remove email verification" action in the send table and the send-details form, which also covers the browser edit flow. The web and desktop onRemoveAuth handlers check the same conditions, so the removal is blocked in code and not only hidden in the UI. New specs cover the service mapping, the table menu visibility and the form's canRemoveAuth computed signal, and no issues were found.

@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.32%. Comparing base (a0c8970) to head (9d1318c).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/web/src/app/tools/send/send.component.ts 0.00% 2 Missing ⚠️
apps/desktop/src/app/tools/send/send.component.ts 50.00% 0 Missing and 1 partial ⚠️
.../components/send-details/send-details.component.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24776      +/-   ##
==========================================
+ Coverage   63.31%   63.32%   +0.01%     
==========================================
  Files        5006     5006              
  Lines      162917   162927      +10     
  Branches    26287    26287              
==========================================
+ Hits       103156   103180      +24     
+ Misses      52765    52753      -12     
+ Partials     6996     6994       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

harr1424
harr1424 previously approved these changes Nov 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review needs-qa Marks a PR as requiring QA approval t:bugfix Change Type - Bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants