Skip to content

PM-46480 resolved desktop active link styling issue - #24702

Open
bmbitwarden wants to merge 2 commits into
mainfrom
PM-46480-active-links-misalignment
Open

bmbitwarden wants to merge 2 commits into
mainfrom
PM-46480-active-links-misalignment

Conversation

@bmbitwarden

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-46480

📔 Objective

Inconsistent borders and misalignment in the “Active links” list of the Share dialog

📸 Screenshots

Screenshot 2026-11-11 at 5 55 21 PM

@bmbitwarden
bmbitwarden requested a review from a team as a code owner November 11, 2026 23:44
@bmbitwarden bmbitwarden added needs-qa Marks a PR as requiring QA approval ai-review Request a Claude code review t:bugfix Change Type - Bugfix labels Nov 11, 2026
@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This review covers the full PR diff, including the new commit 6e87330. In share-item-form.component.html, the "Active links" list no longer uses a hand-built bordered list. It now uses the shared bit-item-group / bit-item / bit-item-content / bit-item-action components, and ItemModule is added to the standalone component's imports. The slot="start", slot="secondary" and <ng-container slot="end"> projections match the content selectors in ItemContentComponent and ItemComponent, and match existing usages such as send-list-items-container.component.html. Element IDs and click handlers are unchanged, and the component spec does not query the replaced markup. No findings.

harr1424
harr1424 previously approved these changes Nov 12, 2026
@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.32%. Comparing base (237e303) to head (6e87330).
⚠️ Report is 73 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24702      +/-   ##
==========================================
+ Coverage   62.86%   63.32%   +0.46%     
==========================================
  Files        4990     5006      +16     
  Lines      160792   162917    +2125     
  Branches    25834    26287     +453     
==========================================
+ Hits       101075   103166    +2091     
+ Misses      52829    52756      -73     
- Partials     6888     6995     +107     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review needs-qa Marks a PR as requiring QA approval t:bugfix Change Type - Bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants