Skip to content

[PM-39986] Add item-type Send filter and row icons - #24326

Open
mcamirault wants to merge 4 commits into
mainfrom
tools/pm-39986/item-type-send-filter-and-row-icons
Open

mcamirault wants to merge 4 commits into
mainfrom
tools/pm-39986/item-type-send-filter-and-row-icons

Conversation

@mcamirault

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-39986

📔 Objective

This PR adds filters for item-type Sends to all clients, as well as new display code that shows an icon that matches the shared item on item-type Send rows in all clients' Send tables.

📸 Screenshots

Web Client

Screen.Recording.2026-10-30.at.14.25.45.mov

Desktop Client

Screen.Recording.2026-10-30.at.14.27.31.mov

Browser Extension

Screen.Recording.2026-10-30.at.14.30.17.mov

@mcamirault
mcamirault requested a review from a team as a code owner October 30, 2026 19:03
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This review covered the Item Send filter added to all three clients. In the browser, the chip filter now shows only the types the policy allows. Desktop gets a new nav entry, and web gets a new toggle and premium-gated ?type=item handling. It also covered the row icons that the Send table and list now take from the existing getSendItemIcon helper, and the allowedSendTypes$ default that now includes Item. Each new locale key is present in every app that renders it, and no new issues were found. The two earlier threads, on desktop policy gating and the feature-flag default, were answered by the author and are not raised again.

@mcamirault mcamirault added needs-qa Marks a PR as requiring QA approval ai-review Request a Claude code review t:feature Change Type - Feature Development labels Oct 30, 2026
@codecov

codecov Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.22%. Comparing base (a95b3af) to head (1e88b67).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/web/src/app/tools/send/send.component.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24326      +/-   ##
==========================================
- Coverage   63.22%   63.22%   -0.01%     
==========================================
  Files        4999     4999              
  Lines      162569   162586      +17     
  Branches    26222    26227       +5     
==========================================
+ Hits       102784   102794      +10     
- Misses      52803    52810       +7     
  Partials     6982     6982              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

harr1424
harr1424 previously approved these changes Nov 16, 2026
@mcamirault
mcamirault enabled auto-merge (squash) November 18, 2026 16:29
@mcamirault mcamirault removed the needs-qa Marks a PR as requiring QA approval label Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants