Skip to content

[PM-44674] Refactor ts-strict for cross team files - #23737

Open
BTreston wants to merge 13 commits into
mainfrom
ac/pm-44674-deferred-ts-strict
Open

BTreston wants to merge 13 commits into
mainfrom
ac/pm-44674-deferred-ts-strict

Conversation

@BTreston

@BTreston BTreston commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-44674

📔 Objective

Refactors the remaining AC models that have cross team impact. The changes are mostly just updating mocks to respect the new contract, however there are a small number of real changes to a few areas.

📸 Screenshots

@BTreston BTreston added ai-review Request a Claude code review t:tech-debt Change Type - Tech debt labels Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

There are no new commits since the last reviewed head, fe367e7 ("fix stories"), so the earlier APPROVE still stands. Both unresolved threads were checked against the current code. In billing-constraint.service.ts:47, the seats == null case now returns { canAddUsers: true }, so that concern is addressed. The vault-filter.service.ts thread is the author's open design question about OrganizationFilter, and nothing in it needs a reviewer finding.

Code Review Details

No new findings.

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 41.07143% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.31%. Comparing base (0516134) to head (fe367e7).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...e/bit-web/src/app/auth/sso/sso-manage.component.ts 0.00% 8 Missing ⚠️
...on/src/admin-console/models/domain/organization.ts 53.84% 4 Missing and 2 partials ⚠️
...key-management/convert-to-key-connector.command.ts 50.00% 2 Missing and 1 partial ⚠️
...s/billing-constraint/billing-constraint.service.ts 25.00% 0 Missing and 3 partials ⚠️
...-members-dialog/invite-members-dialog.component.ts 0.00% 2 Missing ⚠️
...p/billing/settings/sponsoring-org-row.component.ts 0.00% 0 Missing and 2 partials ⚠️
...ilter/components/organization-options.component.ts 0.00% 2 Missing ⚠️
...collections/vault-header/vault-header.component.ts 0.00% 0 Missing and 1 partial ⚠️
...edit-member-dialog/edit-member-dialog.component.ts 0.00% 1 Missing ⚠️
...r-dialog/validators/input-email-limit.validator.ts 0.00% 0 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23737      +/-   ##
==========================================
+ Coverage   63.19%   63.31%   +0.11%     
==========================================
  Files        4999     5006       +7     
  Lines      162523   162946     +423     
  Branches    26207    26319     +112     
==========================================
+ Hits       102711   103166     +455     
+ Misses      52839    52773      -66     
- Partials     6973     7007      +34     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BTreston BTreston changed the title refactor ts strict [PM-44674] Refactor ts-strict for cross team files Oct 13, 2026
@BTreston
BTreston marked this pull request as ready for review October 13, 2026 18:46
@BTreston
BTreston requested review from a team as code owners October 13, 2026 18:46
connerbw
connerbw previously approved these changes Oct 13, 2026
harr1424
harr1424 previously approved these changes Oct 13, 2026
jrmccannon
jrmccannon previously approved these changes Oct 14, 2026

@jrmccannon jrmccannon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the question about a robot's rambling. If that's not an issue, then approval is yours.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes to the auth domain 👍

gbubemismith
gbubemismith previously approved these changes Oct 19, 2026
@BTreston
BTreston dismissed stale reviews from jrmccannon and harr1424 via 8d027bf November 2, 2026 14:50
@BTreston
BTreston requested review from a team as code owners November 2, 2026 14:50
@BTreston
BTreston requested a review from mzieniukbw November 2, 2026 14:50
@BTreston
BTreston marked this pull request as draft November 2, 2026 15:04

@addisonbeck addisonbeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed the Platform file.

Comment thread libs/common/spec/utils.ts
Comment on lines +39 to +54
/**
* Builds an `Organization` for use in tests, with all fields defaulted (mostly `undefined`)
* except for the given overrides.
*/
export function buildTestOrganization(
def: Partial<Omit<Organization, "permissions" | "id">> & {
id?: string;
permissions?: Partial<PermissionsApi>;
} = {},
): Organization {
const { permissions, ...rest } = def;
const org = Object.assign(new Organization(new OrganizationData({} as any, {} as any)), rest);
org.permissions = Object.assign(new PermissionsApi(), permissions ?? {});
return org;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is the right place for this (or that this file should even exist), but I don't have a good alternative to offer. Won't hold you up over it.

@addisonbeck
addisonbeck removed the request for review from dereknance November 18, 2026 18:05

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auth changes LGTM!

@eligrubb eligrubb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KM changes look good

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.