Repository navigation
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE There are no new commits since the last reviewed head, fe367e7 ("fix stories"), so the earlier APPROVE still stands. Both unresolved threads were checked against the current code. In Code Review DetailsNo new findings. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #23737 +/- ##
==========================================
+ Coverage 63.19% 63.31% +0.11%
==========================================
Files 4999 5006 +7
Lines 162523 162946 +423
Branches 26207 26319 +112
==========================================
+ Hits 102711 103166 +455
+ Misses 52839 52773 -66
- Partials 6973 7007 +34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jrmccannon
left a comment
There was a problem hiding this comment.
Just the question about a robot's rambling. If that's not an issue, then approval is yours.
Patrick-Pimentel-Bitwarden
left a comment
There was a problem hiding this comment.
Minor changes to the auth domain 👍
addisonbeck
left a comment
There was a problem hiding this comment.
Just reviewed the Platform file.
| /** | ||
| * Builds an `Organization` for use in tests, with all fields defaulted (mostly `undefined`) | ||
| * except for the given overrides. | ||
| */ | ||
| export function buildTestOrganization( | ||
| def: Partial<Omit<Organization, "permissions" | "id">> & { | ||
| id?: string; | ||
| permissions?: Partial<PermissionsApi>; | ||
| } = {}, | ||
| ): Organization { | ||
| const { permissions, ...rest } = def; | ||
| const org = Object.assign(new Organization(new OrganizationData({} as any, {} as any)), rest); | ||
| org.permissions = Object.assign(new PermissionsApi(), permissions ?? {}); | ||
| return org; | ||
| } | ||
|
|
There was a problem hiding this comment.
Not sure this is the right place for this (or that this file should even exist), but I don't have a good alternative to offer. Won't hold you up over it.
JaredSnider-Bitwarden
left a comment
There was a problem hiding this comment.
Auth changes LGTM!
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-44674
📔 Objective
Refactors the remaining AC models that have cross team impact. The changes are mostly just updating mocks to respect the new contract, however there are a small number of real changes to a few areas.
📸 Screenshots