Android: fix broken stack trace logging in signature/JWT verification - #32
Merged
Conversation
CodePushUtils.log(ex.getStackTrace().toString()) never printed an actual stack trace - getStackTrace() returns an array, and Object.toString() on an array just prints its identity hash (e.g. "[Ljava.lang.StackTraceElement;@1a2b3c"). That line has never been useful. Replace the getMessage()+getStackTrace().toString() pair in verifyAndDecodeJWT, parsePublicKey, and getSignature with a single CodePushUtils.log(Throwable) call, which does print the real trace via Log.e. This is the least-diagnosable failure class in the codebase today (JWT/signature verification failures all collapse into "not signed"/"no public key" with zero trace), so this restores real visibility into those three failure modes.
There was a problem hiding this comment.
Pull request overview
Fixes Android exception logging for signature and JWT verification by emitting real stack traces.
Changes:
- Replaces ineffective exception message/array logging with
CodePushUtils.log(Throwable). - Applies the fix to JWT verification, public-key parsing, and signature reading.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ofalvai
marked this pull request as ready for review
August 17, 2026 09:10
zoltanszabo-bitrise
approved these changes
Aug 17, 2026
sajtizsolt
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a list of quick tactical logging fixes.
CodePushUtils.log(ex.getStackTrace().toString())never printed an actual stack trace:getStackTrace()returns an array, andObject.toString()on an array just prints its identity hash (e.g. "[Ljava.lang.StackTraceElement;@1a2b3c"). That line has never been useful.Replace the
getMessage()+getStackTrace().toString()pair with a singleCodePushUtils.log(Throwable)call, which does print the real trace viaLog.e.