Skip to content

Android: log full exceptions instead of just their message #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofalvai merged 1 commit into from
Aug 17, 2026
Merged

Android: log full exceptions instead of just their message #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/app/src/main/java/com/microsoft/codepush/react/CodePush.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ public String getJSBundleFileInternal(String assetsBundleFileName) {
packageFilePath = mUpdateManager.getCurrentPackageBundlePath(this.mAssetsBundleFileName);
} catch (CodePushMalformedDataException e) {
// We need to recover the app in case 'codepush.json' is corrupted
CodePushUtils.log(e.getMessage());
CodePushUtils.log(e);
clearUpdates();
}

Expand Down
6 changes: 3 additions & 3 deletions android/app/src/main/java/com/microsoft/codepush/react/CodePushNativeModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ private void loadBundle() {
CodePushUtils.log(new Exception("ClassCastException trying to get/use ReactHostDelegate. Skipping reflection call to setJSBundle. This is expected for Expo.", cce));
}catch (Exception e) {
// Catch any unexpected errors from the attempt to call setJSBundle, e.g., if getReactHostDelegate itself fails
CodePushUtils.log("Exception during the reflective setJSBundle block: " + e.getMessage());
CodePushUtils.log(new Exception("Exception during the reflective setJSBundle block", e));
}

// #3) Get the context creation method
Expand All @@ -226,7 +226,7 @@ private void loadBundle() {

} catch (Exception e) {
// reflection logic failed somewhere so fall back to restarting the Activity (if it exists)
CodePushUtils.log("Failed to load the bundle, falling back to restarting the Activity (if it exists). " + e.getMessage());
CodePushUtils.log(new Exception("Failed to load the bundle, falling back to restarting the Activity (if it exists)", e));
loadBundleLegacy();
}
}
Expand Down Expand Up @@ -486,7 +486,7 @@ protected Void doInBackground(Void... params) {
}
} catch (CodePushMalformedDataException e) {
// We need to recover the app in case 'codepush.json' is corrupted
CodePushUtils.log(e.getMessage());
CodePushUtils.log(e);
clearUpdates();
promise.resolve(null);
} catch(CodePushUnknownException e) {
Expand Down
Loading