[jonatack]

bip-0375/deps/dleq.py copied the dleq_* functions from bip-0374/reference.py, depends on it, and could go out of sync (#2262, #2304). Replace it with a loader so the validator always uses the current bip-0374/reference.py.

After that change, the local bip-0375/deps/secp256k1lab copy is unused. Drop the vendored tree, remove its README entry, and point test_runner.py at bip-0374/secp256k1lab/src with an existence check.

This leaves a single source of truth for both the DLEQ functions and the shared secp256k1lab dependency.

Added a note in BIP 374 to indicate 375 is downstream and should be tested before any functional changes to 374's reference.py or its secp256k1lab subtree.

To run the tests:

python bip-0375/test_runner.py

[jonatack]

cc BIP authors @andrewtoth, @achow101, @josibake for feedback

[jonatack]

Rebased following merge of #2286.

[macgyver13]

tACK 503119d

[fametrano]

I suggest also dropping bip-0375/deps/secp256k1lab in this PR, with its README entry, and pointing its path in test_runner.py to bip-0374/secp256k1lab/src. I tried this locally and the 43 tests pass. The path change is needed: with the copy dropped and the path unchanged, importing validator.inputs before deps.dleq fails with ModuleNotFoundError: No module named 'secp256k1lab'.

At 503119d that copy is no longer used. deps/dleq.py loads bip-0374/reference.py, which puts bip-0374/secp256k1lab/src at the front of sys.path. This happens before the validator's first secp256k1lab import. So the validator already runs on BIP-374's copy, as python3 -v bip-0375/test_runner.py shows. The tests pass either way because the two copies are identical today. If they drift apart, no test will notice, and the README will still list the unused copy as a dependency.

[jonatack]

@fametrano good suggestion; done.

[jonatack]

Per an offline suggestion from @macgyver13, added a note in 374 to indicate 375 is downstream and should be tested before any functional changes to 374's reference.py or its secp256k1lab subtree.

[fametrano]

ACK 8f9b1f3

The removed bip-0375/deps/secp256k1lab is the same git tree as bip-0374/secp256k1lab on master (f9ecfa0a), and deps/dleq.py already got BIP 374's copy through bip-0374/reference.py, so pointing test_runner.py there leaves the validator on the same code. Nothing else in the repository refers to the removed copy, and the note added to BIP 374 describes the dependency as it now is. On this head all 43 BIP 375 tests pass.

[macgyver13]

As jonatack described above, I suggested the note in BIP-374 after reconsidering the responsibility this change places on its authors. @theStack @RubenSomsen @andrewtoth, are you OK with BIP-374 asking contributors to run BIP-375's tests before functional changes to reference.py or its secp256k1lab subtree?

If so, I support 8f9b1f3.