Repository navigation
Conversation
theStack
reviewed
Oct 25, 2026
fametrano
force-pushed
the
examples-randomize-erase-keypair
branch
from
October 25, 2026 11:13
86f6a53 to
a560ec6
Compare
theStack
approved these changes
Oct 26, 2026
examples/musig.c is the only example that handles secret keys without randomizing the context, which secp256k1.h highly recommends. Randomize it as schnorr.c does. schnorr.c erases the secret key buffer after use, but the keypair holds a copy of the secret key and stayed on the stack. Erase it too.
fametrano
force-pushed
the
examples-randomize-erase-keypair
branch
from
November 4, 2026 23:03
a560ec6 to
e3b8fc3
Compare
Contributor
Author
|
Rebased on master to resolve the conflict with #1986. The changes are the same; only a context line in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
examples/musig.c is the only example that handles secret keys without
randomizing the context, which secp256k1.h highly recommends. Randomize
it as schnorr.c does.
schnorr.c erases the secret key buffer after use, but the keypair holds
a copy of the secret key and stayed on the stack. Erase it too.