Repository navigation
Update glTF meshopt integration to 0.7 - #26318
Merged
Merged
Conversation
stuartparmenter
added
S-Needs-Review
jbuehler23
approved these changes
Oct 26, 2026
stuartparmenter
added
the
D-Straightforward
hukasu
reviewed
Oct 26, 2026
hukasu
approved these changes
Oct 26, 2026
stuartparmenter
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
I missed updating
bevy_gltfin my previous PR that updatedmeshoptto 0.7. It still depends on 0.6 whilebevy_pbruses 0.7, so a build with both glTF meshopt decoding and meshlets compiles meshoptimizer twice.Solution
Update
bevy_gltftomeshopt0.7 and use its safe encoder in the test fixtures.The decoders and filters still call meshoptimizer directly. I added safe wrappers upstream for 0.7, but they return a new vector, which needs an extra allocation and a copy into the glTF buffer. I benchmarked the safe version and it is ~20% slower, so leaving that one.
Testing
AI Disclosure
This was AI assisted w/ Opus 5.5 as part of my meshopt and tangent generation work. I used Opus to update the glTF integration and to benchmark the 0.7 safe wrappers against the direct decoder calls. I reviewed the changes, tested them, and opened PR.