Skip to content

Fix scene_viewer setup retry when mesh AABBs are missing #25667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alice-i-cecile merged 2 commits into from
Oct 26, 2026
Merged

Fix scene_viewer setup retry when mesh AABBs are missing #25667

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e867e75
Fix scene_viewer setup retry when mesh AABBs are missing
fmterrors Sep 3, 2026
353dfe0
Merge branch 'main' into main
alice-i-cecile Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/tools/scene_viewer/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@ fn setup_scene_after_load(
meshes: Query<(&GlobalTransform, Option<&Aabb>), With<Mesh3d>>,
) {
if scene_handle.is_loaded && !*setup {
*setup = true;
// Find an approximate bounding box of the scene from its meshes
if meshes.iter().any(|(_, maybe_aabb)| maybe_aabb.is_none()) {
return;
Expand Down Expand Up @@ -285,5 +284,7 @@ fn setup_scene_after_load(

scene_handle.has_light = true;
}

*setup = true;
}
}
Loading