Document Playwright E2E strategy and add guest PvP regression coverage in CI#712
Document Playwright E2E strategy and add guest PvP regression coverage in CI#712Copilot wants to merge 9 commits into
Conversation
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/40b5c7be-9532-4fe2-80b4-34427adc6e34 Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/40b5c7be-9532-4fe2-80b4-34427adc6e34 Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/40b5c7be-9532-4fe2-80b4-34427adc6e34 Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
|
@copilot okay can you make a test like this (2 guests play a game, there are some test games in uci.txt) and update the workflow/build.yml file so that the test runs during GitHub build? |
|
@benckx Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
1 similar comment
|
@benckx Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/40b5c7be-9532-4fe2-80b4-34427adc6e34 Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
|
@benckx Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
3 similar comments
|
@benckx Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@benckx Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@benckx Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/0109cd65-0c12-473b-a3fd-4ed58d581b1c Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/0109cd65-0c12-473b-a3fd-4ed58d581b1c Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/0109cd65-0c12-473b-a3fd-4ed58d581b1c Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/0109cd65-0c12-473b-a3fd-4ed58d581b1c Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
Implemented in
Done in |
This issue asked for a better page-testing tool than Selenium and guidance for testing online PvP with two independent guest identities. The PR now includes both documentation guidance and executable regression coverage.
Tooling recommendation
README.md.PvP multi-user test guidance
Executable regression test added
guestPlayersCanPlayFullPvPGameFromUciSample()in:webapp-service-layer/src/test/kotlin/io/elephantchess/servicelayer/services/PlayerVsPlayerGameServiceTest.ktuci.txt(using a sample that ends in checkmate), and verifies completion behavior.GitHub build workflow updated
.github/workflows/build.ymlto verify this exact regression testcase was executed and passed by parsing JUnit XML generated during the build.