Skip to content

Remove Clang 17 and 18 from CI - #34

Merged
wermos merged 1 commit into
mainfrom
river-remove-deprecated-clang
Oct 28, 2026
Merged

wermos merged 1 commit into
mainfrom
river-remove-deprecated-clang

Conversation

@wusatosi

Copy link
Copy Markdown
Member

Remove unsupported clang version from build-and-test pipeline. For more infomation, See: bemanproject/beman#221

disclosure: PR generated using codex

@wusatosi
wusatosi requested a review from wermos as a code owner October 27, 2026 06:48
Remove unsupported clang version from build-and-test pipeline. For more infomation, See: bemanproject/beman#221
@wusatosi
wusatosi force-pushed the river-remove-deprecated-clang branch from b9c933a to d33f031 Compare October 28, 2026 05:38

@wermos wermos left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I am missing something, this PR does not actually remove Clang 17 and 18 from the CI. It just appears to reformat those lines

The PR title is a phenomenally bad one and completely gives the wrong idea of what the PR is supposed to do. Looking through the linked issue, I understand what the actual change is now.

@wermos wermos left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wermos
wermos merged commit ac3ab55 into main Oct 28, 2026
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants