Importer variable nomenclature is not compatible with fava

[mlell]

fava v1.30.7 expects the importer configuration to be a Python module with the variables CONFIG and HOOKS:

https://github.com/beancount/fava/blob/d6968fa0c3a48d42365532167faa23a4550a04f4/src/fava/core/ingest.py#L334-L336

However, the example calls them importers and hooks.

beangulp/examples/import.py

Lines 12 to 25 in c5e8188

	importers = [
	utrade.Importer(
	"USD",
	"Assets:US:UTrade",
	"Assets:US:UTrade:Cash",
	"Income:US:UTrade:{}:Dividend",
	"Income:US:UTrade:{}:Gains",
	"Expenses:Financial:Fees",
	"Assets:US:BofA:Checking",
	),
	ofx.Importer("379700001111222", "Liabilities:US:CreditCard", "bofa"),
	acme.Importer("Assets:US:ACMEBank"),
	csvbank.Importer("Assets:US:CSVBank", "USD"),
	]

This is confusing and not documented anywhere. How about renaming the variables in the example? This would make things easier for new users.

[wuqs-net]

Not entirely related, but did you get it to work after renaming the variables? I'm getting

Error in import config '/home/qqq/beangulp/examples/import.py': Traceback (most recent call last):
  File "/home/qqq/beancount/.venv/lib/python3.12/site-packages/fava/core/ingest.py", line 331, in load_import_config
    mod = run_path(str(module_path))
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen runpy>", line 286, in run_path
  File "<frozen runpy>", line 98, in _run_module_code
  File "<frozen runpy>", line 88, in _run_code
  File "/home/qqq/beangulp/examples/import.py", line 3, in <module>
    from importers import acme
ModuleNotFoundError: No module named 'importers'

[mlell]

ModuleNotFoundError: No module named 'importers'

I do not know enough about what you did to get this error. What exactly you are trying to do, your code, etc. The error means that it cannot find the module "importers". Maybe "beangulp.importers" works. That is indeed a different issue, so maybe you open a new issue with a more thorough and, most importantly, reproducible description of what you did, what you expected to see, and what you got instead