pyo3: make //toolchains:pyo3 publicly visible - #4217
Open
georgew-arta wants to merge 1 commit into
Open
Conversation
`//toolchains:pyo3` (the `rust_library_group` wrapping `@rpyo3c//:pyo3`) is the natural target for `rust_library` crates that need to link against pyo3 outside of a `pyo3_extension` (e.g. a shared bridge library used by several extensions). Today it is package-private, so consumers are forced to hard-code the bzlmod canonical repo label (`@@rules_rust_pyo3~~rust_ext~rpyo3c//:pyo3`) or `use_repo` the internal `rust_ext` extension — both couple them to implementation details that change across Bazel/bzlmod releases. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
//toolchains:pyo3(therust_library_groupwrapping@rpyo3c//:pyo3) is the natural dependency for plainrust_librarycrates that link against pyo3 outside of apyo3_extension— e.g. a shared bridge library consumed by several extensions.Today the target is package-private, so consumers have to either hard-code the bzlmod canonical repo label (
@@rules_rust_pyo3~~rust_ext~rpyo3c//:pyo3) oruse_repothe internalrust_extextension from//private:internal_extensions.bzl— both couple downstream workspaces to implementation details (canonical-name mangling, internal extension paths) that change across Bazel releases.This makes the existing target publicly visible so it can serve as the supported label, one line:
🤖 Generated with Claude Code