fix: prefix pwd for compiler response file paths - #4216
Open
KirillTim wants to merge 2 commits into
Open
Conversation
also extract _pwd_flags_* functions to a list to improve readability
Only the path to the response file is fixed. Its contents are left untouched and may be not resolved if contains execroot-relative paths.
KirillTim
force-pushed
the
kirilltim/prefix_pwd_for_compiler_response_files
branch
from
August 9, 2026 04:13
b2288e4 to
be6e1b0
Compare
Author
|
This PR is branched from #4215 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our prebuilt
clangships with a compiler response file containing multiple-Dswitches.While
cc_toolchainalready handles passing this file in our main build, we also need to pass it toclanginvocations made insideCargo.Passing the response file directly is much simpler and more robust than reading the file and injecting its contents into the
CXXFLAGSlist.Only the path to the response file is fixed. Its contents are left untouched and may be not resolved if contains execroot-relative paths. I believe it is still an positive improvement.
Tested: