Use Starlark tuples for extra link-time libraries - #812
Open
dzbarsky wants to merge 1 commit into
Open
Conversation
dzbarsky
marked this pull request as ready for review
July 31, 2026 18:25
Collaborator
|
Looks reasonable and my guess is it'll save memory, but I don't have the time to run benchmarks right now; will take another look when someone has time. |
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Java-backed
_cc_internal.freezecalls in extra-link-time library grouping and collections with immutable Starlark tuples. Grouping keys remain hashable, constant and depset fields retain their ordering, and empty, singleton, and merged library collections preserve their existing behavior.Add three focused regression tests covering grouping-key equality, tuple-valued collections, and merged depsets.
Validation:
buildifier -mode=checkand three passing//tests/cc/common:extra_link_time_library_testscases.