Skip to content

Fix FixedNBins marginal-mode dispatch - #559

Open
BJMCox wants to merge 1 commit into
mainfrom
fix-551-fixed-nbins-dispatch
Open

Fix FixedNBins marginal-mode dispatch#559
BJMCox wants to merge 1 commit into
mainfrom
fix-551-fixed-nbins-dispatch

Conversation

@BJMCox

@BJMCox BJMCox commented Aug 16, 2026

Copy link
Copy Markdown
Member

Fixes #551.

Implement FixedNBins at the existing _get_bining_impl seam used by _get_binedges. The internal spelling remains unchanged to avoid unrelated churn.

Main code: +1/-1.

@BJMCox BJMCox self-assigned this Aug 16, 2026
@codecov

codecov Bot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.83%. Comparing base (6e8795f) to head (2a1bebf).

Files with missing lines Patch % Lines
src/statistics/binning_rules.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
+ Coverage   65.45%   65.83%   +0.38%     
==========================================
  Files         121      121              
  Lines        7060     7060              
==========================================
+ Hits         4621     4648      +27     
+ Misses       2439     2412      -27     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BJMCox
BJMCox force-pushed the fix-551-fixed-nbins-dispatch branch from cfd3ba0 to 0200f0c Compare August 31, 2026 15:19
@BJMCox
BJMCox force-pushed the fix-551-fixed-nbins-dispatch branch from 0200f0c to 2a1bebf Compare September 1, 2026 12:06
@BJMCox
BJMCox marked this pull request as ready for review September 1, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FixedNBins fails in marginal-mode estimation

1 participant