docs(base-account): drop .mdx extension from signInWithEthereum link#1333
Open
MukundaKatta wants to merge 1 commit intobase:masterfrom
Open
docs(base-account): drop .mdx extension from signInWithEthereum link#1333MukundaKatta wants to merge 1 commit intobase:masterfrom
MukundaKatta wants to merge 1 commit intobase:masterfrom
Conversation
Mintlify routes are served without the .mdx extension, so the current link /base-account/reference/core/capabilities/signInWithEthereum.mdx returns 404. Removed the suffix to match all sibling links. Closes base#1311
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`docs/base-account/reference/core/provider-rpc-methods/wallet_connect.mdx:193` links to `/base-account/reference/core/capabilities/signInWithEthereum.mdx`. Mintlify routes are published without the `.mdx` suffix, so the link 404s.
Removed the extension so the link resolves to `/base-account/reference/core/capabilities/signInWithEthereum`.
Closes #1311
Testing
Docs-only change. Verified: