ci: move release automation into account workflow#294
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Heimdall Review Status
|
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
| - name: Publish to npm | ||
| run: | | ||
| cd packages/account-ui | ||
| npm publish --tag latest --access public --provenance |
There was a problem hiding this comment.
The @base-org/account-ui npm Trusted Publisher configuration (if one exists) would have been tied to the old workflow filename release-please.yml. Moving this publish job to release-account.yml will break OIDC-based publishing for account-ui unless the Trusted Publisher entry on npm has already been updated to reference the new filename.
Please verify that either:
@base-org/account-ui's npm Trusted Publisher is updated torelease-account.yml, or@base-org/account-uidoesn't use Trusted Publishing (relies on an NPM_TOKEN secret instead)
If (1), this is fine. If neither, automated account-ui publishes will fail with a 403 on the next release.
There was a problem hiding this comment.
account-ui is low prio for now, will work on it separately
Review SummaryPR consolidates release-please automation and the existing manual publish workflow into a single Findings
Previously addressed (no action needed)Both items from the prior review round are resolved in the current diff:
Notes
|
Summary
release-account.ymlworkflow.masterpackage version oraccount-v<version>tag before publishing.Test plan
git diff --check origin/master...HEADruby -e 'require "yaml"; YAML.load_file(".github/workflows/release-account.yml"); puts "yaml ok"'Made with Cursor