Conversation
The Cancel button sat in a bottom overlay with a fixed 120pt inset, which put it on top of the Log In button, and the view already sets ignoresSafeArea(.keyboard, edges: .bottom) so a bottom anchor had no relationship to the keyboard at all. It moves to the top-leading corner. This is the only way out of add-account: the cover is presented with interactiveDismissDisabled(), so swipe-to-dismiss is off. White text on 15%-white also read as scenery rather than a button. The background goes to 92% white with a black label.
Collaborator
Author
|
Superseded by #449, which consolidates first-run and add-account onto one entry point. Closing rather than merging: this branch's commit ( Comment written by an agent on behalf of @dmnyc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cancel button sat in
.overlay(alignment: .bottom)with a fixed.padding(.bottom, 120), which put it on top of the Log In button. The view already sets.ignoresSafeArea(.keyboard, edges: .bottom), so a bottom anchor had no relationship to the keyboard at all — with it open the button was unreachable.It moves to
.topLeadingwith 16pt insets, matching where the Android apps put theirs.Worth noting this is the only way out of add-account:
ContentViewpresents the cover with.interactiveDismissDisabled(), so swipe-to-dismiss is off.White text on 15%-white also read as scenery rather than a button, so the background goes to 92% white with a black label.
Verified with a Debug build for the iOS Simulator. Not exercised against a live sign-in.