fix(opencode): honor cli runtime for command routing#962
Closed
snvtac wants to merge 1 commit into
Closed
Conversation
Owner
|
Closing this. #947 wasn't a routing bug, it was a frontend crash (same as #949), already fixed in 0.21.1. The runtime change doesn't touch it. Both paths served the same broken page. Also, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runtime: "cli"is an explicit first-class CLI pathsubmit_plan, keeping source checkouts and CLI-only workflows independent of embedded assets/plannotator-last,/plannotator-annotate,/plannotator-review, and CLIsubmit_planwithout bundled HTMLIssue
Fixes #947
Verification
bun test apps/opencode-plugin/*.test.tsPATH="$PWD/apps/hook/node_modules/.bin:$PWD/packages/ui/node_modules/.bin:$PATH" BUN_INSTALL_CACHE_DIR="$PWD/../bun-cache" bun run typecheckbun testgit diff --checkbun build embedded.ts --outfile dist/embedded.js --target bun --external @opencode-ai/plugin && bun build index.ts --outfile dist/index.js --target node(run fromapps/opencode-pluginwith the system Bun binary)