feat: add cargo install fallback for dist prebuilt binary installation - #2352
feat: add cargo install fallback for dist prebuilt binary installation#2352ChanTsune wants to merge 1 commit into
Conversation
When a prebuilt binary installer is unavailable for the target architecture (e.g. riscv), the generated CI workflow now falls back to `cargo install cargo-dist --locked --version <version>` instead of failing outright.
|
I'm not sure if this is the right approach. This will catch any |
|
Hi, I came at this from the other end: I added riscv64 release targets to atuin, they merged, and then had to revert a day later (atuinsh/atuin#3745) because the release workflow can't install dist on a riscv64 runner. So this thread is the blocker for us too, and I'd rather help finish it than open something competing. @mistydemeo, your objection makes sense to me. The pieces for the narrower version look like they're already in place. It also stays out of the way of the existing snapshots. Since the generated command only changes for hosts that have no binary today, the 60-odd .snap files in this PR would go back to unchanged, and it'd add one new case covering a custom runner on a target dist doesn't ship. @ChanTsune, this is your issue and your PR, so I don't want to step on it. Happy to push that version to your branch if you'd like, or open a separate PR that credits you, or just leave it with you if you were already partway there. Whichever you prefer. |
When a prebuilt binary installer is unavailable for the target architecture (e.g. riscv), the generated CI workflow now falls back to
cargo install cargo-dist --locked --version <version>instead of failing outright.resolve #2351