Skip to content

fix: typo in variable name - #2223

Merged
mistydemeo merged 1 commit into
axodotdev:mainfrom
20jasper:typo
Dec 28, 2025
Merged

fix: typo in variable name#2223
mistydemeo merged 1 commit into
axodotdev:mainfrom
20jasper:typo

Conversation

@20jasper

@20jasper 20jasper commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

Fixes a typo in the builderGlibcMInorVersion. The I in MInor shouldn't be capitalized

@mistydemeo

Copy link
Copy Markdown
Contributor

Oops, thanks!

@20jasper
20jasper force-pushed the typo branch 3 times, most recently from 4343e8b to 012a268 Compare December 26, 2025 23:53
@20jasper

20jasper commented Dec 27, 2025

Copy link
Copy Markdown
Contributor Author

UPDATE: I got the test to pass via installing specifically version 0.7.0 of omnibor-cli like the github action. omnibor-cli@0.9.3 does not work. I'd be glad to make a followup PR to include this in contributing instructions if y'all would be interested

Running the github action on my fork passes all checks https://github.com/20jasper/cargo-dist/actions/runs/20531652494/job/58983776926?pr=2


ORIGINAL: For transparency, I just pushed a manual update to the snapshot for the failing axolotlsay_basic integration test since I had quite a lot strife trying to get it to pass locally, even on main. I couldn't find anything in the CONTRIBUTING.md referencing anything special to run and the devenv.nix implies I shouldn't need anything beyond cargo-insta

Any tips on how to get this test working?

I get "command not found" when running all tests on main

running dist build -aglobal...
Error:   × "cargo-dist dist build -aglobal" failed (exit status: 255)
  ╰─▶ 
      stdout:
      
      stderr:
        × The following tools are required to run this task, but are missing:
        │ - omnibor-cli
        help: Please install the tools mentioned above and try again.

After installing omnibor-cli via cargo-binstall, I get failed to generate an OmniBOR Artifact ID

running dist build -aglobal...
Error:   × "cargo-dist dist build -aglobal" failed (exit status: 255)
  ╰─▶ 
      stdout:
      
      stderr:
      building artifacts:
        source.tar.gz
        source.tar.gz.sha256
        source.tar.gz.omnibor
        axolotlsay-installer.sh
        axolotlsay-installer.ps1
        axolotlsay.rb
        axolotlsay-npm-package.tar.gz
        axolotlsay.cdx.xml
        sha256.sum
      
        × failed to generate an OmniBOR Artifact ID (status: exit status: 2)

@mistydemeo

Copy link
Copy Markdown
Contributor

Oh! That's why some people have been having trouble running that test! Right, that one is testing calling the omnibor commandline tool and expects to actually have access to it. I hadn't considered that would be breaking running that test for most people.

@mistydemeo

Copy link
Copy Markdown
Contributor

I'd be glad to make a followup PR to include this in contributing instructions if y'all would be interested

Thank you!

@20jasper

Copy link
Copy Markdown
Contributor Author

I'd be glad to make a followup PR to include this in contributing instructions if y'all would be interested

Thank you!

Made a draft PR and included some doubts I had! #2234

@mistydemeo mistydemeo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mistydemeo
mistydemeo merged commit f5ba2fd into axodotdev:main Dec 28, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants