Repository navigation
Support JCB credit card numbers - #769
Open
Mr-KnightCLI wants to merge 1 commit into
Open
Mr-KnightCLI wants to merge 1 commit into
Mr-KnightCLI wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #533 by extending
Patterns.CREDITCARDto recognize JCB card numbers in the 3528–3589 range. Regression cases cover the two examples in the issue and space- and hyphen-separated formats.Validation
-Dfile.encoding=UTF-8).AnalyzerTestssuite could not complete on this Windows machine because Spark requires Hadoopwinutils.exe, which is not installed. The suite failed during SparkContext setup before test assertions ran.