Skip to content

Support JCB credit card numbers - #769

Open
Mr-KnightCLI wants to merge 1 commit into
awslabs:masterfrom
Mr-KnightCLI:533-jcb-credit-card-support
Open

Mr-KnightCLI wants to merge 1 commit into
awslabs:masterfrom
Mr-KnightCLI:533-jcb-credit-card-support

Conversation

@Mr-KnightCLI

Copy link
Copy Markdown

Summary

Closes #533 by extending Patterns.CREDITCARD to recognize JCB card numbers in the 3528–3589 range. Regression cases cover the two examples in the issue and space- and hyphen-separated formats.

Validation

  • Scala compilation and Scalastyle passed under Java 11 (-Dfile.encoding=UTF-8).
  • A standalone check of the exact Java regex passed seven accepted card formats and rejected three out-of-range/invalid examples.
  • The targeted AnalyzerTests suite could not complete on this Windows machine because Spark requires Hadoop winutils.exe, which is not installed. The suite failed during SparkContext setup before test assertions ran.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.


Generated by AI (model: us.anthropic.claude-opus-4-8, prompt: 4d2f5d73) — may not be fully accurate. Reply if this doesn't help.
Reviewed by Shadow · github.com/sudsali/shadow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

containsCreditCardNumber analyser constraint doesnt support for JCB credit card

1 participant