feat(payments): add AgentCore Payments as first-class CLI resource#1261
Open
aidandaly24 wants to merge 3 commits into
Open
feat(payments): add AgentCore Payments as first-class CLI resource#1261aidandaly24 wants to merge 3 commits into
aidandaly24 wants to merge 3 commits into
Conversation
github-actions
Bot
added
the
agentcore-harness-reviewing
Contributor
Package TarballHow to installgh release download pr-1261-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.16.0.tgz |
github-actions
Bot
removed
the
agentcore-harness-reviewing
aidandaly24
force-pushed
the
feat/payments
branch
from
31df340 to
5425a52
Compare
aidandaly24
force-pushed
the
feat/payments
branch
from
6bb9d46 to
59d48ee
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: the review run failed before completing. See the run for details. |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: the review run failed before completing. See the run for details. |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
aidandaly24
force-pushed
the
feat/payments
branch
from
7db4a90 to
15742eb
Compare
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
|
Claude Security Review: the review run failed before completing. See the run for details. |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
jesseturner21
requested changes
Jun 2, 2026
Contributor
jesseturner21
left a comment
jesseturner21
left a comment
There was a problem hiding this comment.
Looks good! just a few questions and maybe a quick change to update the schema to match the api.
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Adds AgentCore Payments as a first-class resource type in the CLI: - `agentcore add/remove payment-manager` and `payment-connector` (CoinbaseCDP + StripePrivy), CLI + TUI wizard - Cascading delete of connectors + credentials + .env.local cleanup - CDK-backed deploy via AgentCorePaymentManager / AgentCorePaymentConnector L3 constructs, including runtime-role payment data-plane IAM grants - Payment credential provider setup (imperative, AgentCore Identity vault) - CFN output parsing into deployed-state - Invoke flags: --payment-instrument-id, --payment-session-id, --auto-session - Strands template wires AgentCorePaymentsPlugin; PAYMENT_SYSTEM_PROMPT references the plugin-provided http_request tool Schema: - payments[] in agentcore.json, .optional() (non-breaking: absent configs are not rewritten with payments: []) - payment manager name regex matches CreatePaymentManager API (no underscore); connector names allow underscores per CreatePaymentConnector - getOrCreatePaymentSession unwraps the CreatePaymentSession `paymentSession` response so --auto-session forwards a real session id Verified end-to-end on Base Sepolia: real on-chain USDC settle via the SDK plugin (bedrock-agentcore >= 1.12.0 / PR #493).
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
The vended cdk/bin/cdk.ts compiles against the published @aws/agentcore-cdk schema type, which lags the CLI's AgentCoreProjectSpec (no payments/harnesses fields). Restore `const specAny = spec as any` and route payments/harnesses/ gateway field access through it, fixing TS2304 (specAny undefined) and TS2339 (payments missing) introduced while resolving the rebase conflict in this file. Regenerates the asset snapshot to match.
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
# Conflicts: # src/lib/packaging/helpers.ts
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds AgentCore Payments as a first-class resource type in the CLI. Includes:
agentcore add payment-manager/payment-connectorcommands (CLI + TUI wizard)agentcore remove payment-manager/payment-connectorwith cascading deleteAgentCorePaymentManager+AgentCorePaymentConnectorL3 constructs--payment-instrument-id,--payment-session-id,--auto-sessionRelated Issue
Closes #
Documentation PR
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshots120 new payment-specific unit tests added covering:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.
Update — runtime IAM + system prompt for x402 auto-pay (commit 1f6a2f2)
End-to-end testing surfaced a missing IAM grant and a stale system prompt. Both blockers are fixed in this commit; the rest of the PR is unchanged.
What broke without the fix
The agent runtime role only had
sts:AssumeRoleon theProcessPaymentRole(which carries onlyProcessPayment). ButAgentCorePaymentsPlugin.generate_payment_headercallsGetPaymentInstrumenton the runtime's own credentials before any role assumption. The plugin failed withAccessDeniedExceptionon the very first 402 it tried to settle:Fix
Grant the runtime role the seven payment data-plane actions, scoped to the manager ARN, in the vended CDK stack template:
bedrock-agentcore:GetPaymentInstrumentbedrock-agentcore:ListPaymentInstrumentsbedrock-agentcore:GetPaymentInstrumentBalancebedrock-agentcore:GetPaymentSessionbedrock-agentcore:ListPaymentSessionsbedrock-agentcore:CreatePaymentSession(so--auto-sessionworks without a separate ManagementRole call)bedrock-agentcore:ProcessPaymentA code comment notes this deviates from the canonical 4-role split in the AgentCore Payments beta guide. The deviation is required by the current SDK plugin, which calls
GetPaymentInstrumentfrom insidegenerate_payment_header. If the SDK is later updated to accept a pre-fetched instrument and to split create-session into a backend-only flow, this grant can be tightened.System-prompt update
PAYMENT_SYSTEM_PROMPTincapabilities/payments/payments.pynow mentions thehttp_requesttool that the SDK plugin auto-registers:The other prompt lines (for
get_payment_session,get_payment_instrument_balance,list_payment_instruments) are unchanged — those tools were already provided by the plugin.SDK dependency
This commit's system-prompt change is forward-looking; the
http_requesttool ships in bedrock-agentcore SDK PR aws/bedrock-agentcore-sdk-python#493. Once that merges and a new SDK release ships, the template'spyproject.toml.hbsshould pinbedrock-agentcore >= <released-version>. Pin bump intentionally NOT included in this commit — it should land alongside the published version number.End-to-end verification (after IAM fix + SDK PR)
Tested against
https://x402.bitcoinsapi.com/weatheron Base Sepolia from a fresh project. Plugin path runs cleanly:Detected 402 Payment Required response from tool: http_requestSuccessfully retrieved instrument(← fails without this commit's IAM grant)Successfully processed payment for user default-user(← fails without SDK PR feat: addagentcore tracescommand and trace link in invoke TUI #493)Added payment header to tool input headers: ['PAYMENT-SIGNATURE'](Final on-chain settle currently fails inside the seller-side facilitator simulation due to two unrelated issues in CDP's signing service —
validAfterset to current timestamp instead ofnow-N, and an ECRecover failure on the returnedvbyte. Those are tracked separately as service-side bugs and are out of scope for this PR.)