feat: add DBInstanceParameterGroupName field to DBCluster - #293
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a09cb2e to
30ba1dc
Compare
| } | ||
| if requireEngineVersionUpdate(desired.ko.Spec.EngineVersion, latest.ko.Spec.EngineVersion, autoMinorVersionUpgrade) { | ||
| res.EngineVersion = desired.ko.Spec.EngineVersion | ||
| if desired.ko.Spec.DBInstanceParameterGroupName != nil { |
There was a problem hiding this comment.
Q: From the API docs it sounds like this field is only valid during a major version upgrade. Do we need to check that DBInstanceParameterGroupName is in the delta before including it to prevent an error during a subsequent minor version upgrade?
| assert.Nil(t, input.PreferredBackupWindow) | ||
| } | ||
|
|
||
| func TestNewCustomUpdateRequestPayload_DBInstanceParameterGroupName_MajorUpgrade(t *testing.T) { |
There was a problem hiding this comment.
Do we need a test for the below scenarios?
- No engine version change
- A minor version engine change.
There was a problem hiding this comment.
Would be good to have an e2e test for the major version engine upgrade case.
9ece93b to
0eb40ca
Compare
f1dc271 to
0e89455
Compare
The field is sourced from ModifyDBCluster and only sent to AWS during a major engine version upgrade, since AWS accepts it in combination with AllowMajorVersionUpgrade for a major version upgrade only. This enables Aurora clusters with custom instance parameter groups to upgrade successfully. Add a DBParameterGroup reference so the parameter group can be resolved via dbInstanceParameterGroupRef. Resolves aws-controllers-k8s/community#2778
0e89455 to
a7fed84
Compare
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Description of changes:
The field is sourced from ModifyDBCluster and passed to AWS only during
major engine version upgrades, enabling Aurora clusters with custom
instance parameter groups to upgrade successfully.
Mark field with compare.is_ignored to prevent infinite reconciliation
since AWS never returns it in DescribeDBClusters.
Resolves aws-controllers-k8s/community#2778
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.