Update CloudWatch SDK to v1.65.0 - #74
Conversation
ack-prow
Bot
added
the
needs-ok-to-test
|
Hi @micahhausler. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
ack-prow
Bot
added
ok-to-test
|
/label release/minor |
ack-prow
Bot
added
the
release/minor
|
@micahhausler Nice to have but not required, updating the existing e2e test to exercise these new fields during create and update operations. |
|
Attribution needs updated after this change, if you can take a look at https://github.com/aws-controllers-k8s/ack-dev-skills It would have context on updating the attribution. |
| - InsightRule | ||
| - ManagedInsightRule | ||
| # - MetricStream | ||
| field_paths: |
There was a problem hiding this comment.
This should be fine. It seems like tag support was recently added for this resource in a later sdk version. We can consider tag support for dashboard out of scope for this PR.
The CloudWatch alarm evaluation window fields (EvaluationWindow, WallClockWindow, SlidingWindow) are absent from the botocore model in 1.43.36, so describe_alarms silently drops them and service controller e2e tests cannot assert on them. botocore 1.43.56 includes them. Issue #, if available: N/A Needed for e2e tests in aws-controllers-k8s/cloudwatch-controller#74 Description of changes: By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Bump cloudwatch service models and adds support for evaluationCriteria and evaluationInterval for MetricAlarms
knottnt
left a comment
knottnt
left a comment
There was a problem hiding this comment.
Thanks @micahhausler!
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knottnt, micahhausler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Releasing changes: * #74
3 participants
Bump cloudwatch service models and adds support for evaluationCriteria and evaluationInterval for MetricAlarms
Issue #, if available:
N/A
Description of changes:
I bumped the AWS SDK to support the PromQL and OTEL changes released in April 2026.
This implements @knottnt's comment on #63.
Two things I was unsure about:
PutDashboardInput.TagsfieldSlidingWindowAPI docs and User Guide specify that it is an empty object field, so I added it toempty_shapesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.