virttest: handle failed qmp_cmds without crashing - #4351
Open
bssrikanth wants to merge 1 commit into
Open
bssrikanth wants to merge 1 commit into
bssrikanth wants to merge 1 commit into
Conversation
Contributor
Author
|
Before fix: After fix: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the QMP command discovery process in virttest/qemu_devices/qcontainer.py. It introduces explicit logging when QMP commands are unparsable or missing and adds a safety check in has_qmp_cmd to handle empty command lists. I have no feedback to provide.
get_qmp_cmds could return None when the query-commands probe produced no parseable output, so has_qmp_cmd did cmd in None and raised TypeError. Always return a list (empty on failure), log a warning, and treat an empty command set as unsupported so capability checks return false instead of crashing. Signed-off-by: Srikanth Aithal <sraithal@amd.com>
Contributor
Author
Contributor
|
Closing this PR due to current team constraints. This is part of a broader effort to triage all in-flight work across our upstream repos. If this work is still needed, please feel free to reopen and it will be picked up. Apologies for any inconvenience. |
Contributor
Author
|
I dont have permission to reopen. This PR is fixing a issue in the framework, I would appreciate if this fix gets in. In anyway I could help here I will be happy to help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_qmp_cmds could return None when the query-commands probe produced no parseable output, so has_qmp_cmd did cmd in None and raised TypeError.
Always return a list (empty on failure), log a warning, and treat an empty command set as unsupported so capability checks return false instead of crashing.