Conversation
Libvirt now reports "doesn't support some additional attributes" instead of "doesn't support additional attributes". Update the expected error string so caching_mode, eim, and iotlb variants pass on RHEL 10.3. Assisted-by: Claude AI (cursor) ~80% Signed-off-by: hholoubk <hholoubk@redhat.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Match both libvirt error wordings with a regex pattern instead of a fixed string. Document that aw_bits is supported since libvirt 12.2.0 and is skipped on RHEL 10.3+ viommu jobs via ci-shared-datas. Assisted-by: Claude AI (cursor) ~85% Reference: RHEL-76269 Signed-off-by: hholoubk <hholoubk@redhat.com>
crobinso
left a comment
crobinso
left a comment
There was a problem hiding this comment.
looks fine with the comment tweaks. PR is in draft. do you still need it?
| start_vm = "no" | ||
| enable_guest_iommu = "yes" | ||
| err_msg = "iommu model 'virtio' doesn't support some additional attributes" | ||
| # Match old and new libvirt rejections for unsupported virtio-iommu attrs |
There was a problem hiding this comment.
comment is redundant IMO
| iommu_dict = {'driver': {'iotlb': 'on'}, 'model': 'virtio'} | ||
| # aw_bits is supported for virtio-iommu since libvirt 12.2.0 (RHEL-76269, | ||
| # RHEL 10.3+). RHEL 10.3 viommu jobs skip this variant via ci-no in | ||
| # ci-shared-datas; positive coverage will be added separately. |
There was a problem hiding this comment.
should we be referencing downstream ci-shared-datas in upstream tp-libvirt? IMO just drop the comment. this looks like AI agents being too wordy with comments
2 participants
Libvirt now reports "doesn't support some additional attributes" instead of "doesn't support additional attributes". Update the expected error string so caching_mode, eim, and iotlb variants pass on RHEL 10.3.
Assisted-by: Claude AI (cursor) ~80%