fix: omit subseconds from redelivery dates - #1068
Closed
Dodothereal wants to merge 1 commit into
Closed
Conversation
Assisted-by: Claude Code
Contributor
|
Hi @Dodothereal 👋 Thank you for taking the time to dig into this. We appreciate your effort to raise this PR, however, we're going to go forward with #1087, which has a very similar approach.
Just to be clear, none of this is a knock on the contribution, the diagnosis was correct and the fix shape was right. It came down to the timezone edge cases and how we manage custom-code alongside fern-generated code. If you are up for contributing again, we genuinely welcome it. Just a heads-up, according to our contribution guidelines you will need to have your commits verified. Thanks again for helping make the SDK better 🤝 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: omit subseconds from redelivery dates
Summary
Redeliveries.CreateAsyncserializeddate_fromanddate_towith milliseconds, although the endpoint accepts RFC 3339 values only to whole-second precision. This change applies a request-specific serializer that omits fractional seconds while preserving theDateTimeoffset/kind. The behavior is covered through the redelivery mock-server request assertion.Fixes #1067
Changes
CreateEventStreamRedeliveryRequestContent.DateFromandDateTowithout sub-second precision.Testing
git diff --checkcompleted successfully.sandbox-run "dotnet test tests/Auth0.ManagementApi.Test/Auth0.ManagementApi.Test.csproj --no-restore"could not run because the sandbox image does not includedotnet(dotnet: command not found).sandbox-run "dotnet test tests/Auth0.ManagementApi.Test/Auth0.ManagementApi.Test.csproj"also could not run for the same reason.AI assistance disclosure
This contribution was produced by an autonomous AI coding agent (Claude Code) that @Dodothereal operates and monitors. @Dodothereal is accountable for it, will address review feedback promptly, and will close this PR immediately if this kind of contribution is unwelcome in this project. Commits carry an
Assisted-by: Claude Codetrailer.