Skip to content

Use Taffy-branded logo#428

Closed
JamoCA wants to merge 3 commits into
atuttle:mainfrom
JamoCA:main
Closed

Use Taffy-branded logo#428
JamoCA wants to merge 3 commits into
atuttle:mainfrom
JamoCA:main

Conversation

@JamoCA

@JamoCA JamoCA commented Mar 31, 2022

Copy link
Copy Markdown
Contributor

Use transparent PNG (using data URI) for favicon & H1 header on dashboard.

JamoCA added 2 commits March 30, 2022 18:58
Remove 3rd party dependence (fav.farm) and use embedded PNG.
I added a non-repeatable background image to the H1 header. (I don't use LESS, so I'm not sure what to do there.)
@netlify

netlify Bot commented Mar 31, 2022

Copy link
Copy Markdown

Deploy Preview for taffy-docs canceled.

Name Link
🔨 Latest commit c14b5e7
🔍 Latest deploy log https://app.netlify.com/sites/taffy-docs/deploys/62450c2a3f0e7a000882862b

@JamoCA JamoCA mentioned this pull request Mar 31, 2022
@atuttle

atuttle commented Apr 13, 2022

Copy link
Copy Markdown
Owner

Rather than embed it as a data-image twice, why not create a file and link to that?

@JamoCA

JamoCA commented Apr 19, 2022

Copy link
Copy Markdown
Contributor Author

The data URIs are actually different. I used a smaller favicon generated by RealFavIconGenerator [https://realfavicongenerator.net/] and think I used an SVG for the logo.

I reviewed the main source and noticed that two (2) CSS files were included using cfinclude (rather than using a regular HTML link tag). I also noticed that the none of the CFM/CFC files used img tags. While there is a logo-lg.png file, it is only used for the readme.md file, isn't a square image and wasn't used anywhere else. I'm not sure why this was done, but thought it could be due to path issues and I didn't want to create any problems.

I can generate both static resource files if you'd prefer to use them instead. (I cropped the readme logo and submitted it to RealFaviconGenerator.)

@atuttle

atuttle commented Apr 27, 2022

Copy link
Copy Markdown
Owner

Yes, please. Let's use static files.

qToArray built each row as a plain struct, so the key order depended on the CFML engine's hash order. Switching the row literal to [:] gives an ordered struct, which keeps the column order you see in the database or in the SELECT list. Callers that serialize rows to JSON now get predictable field order for free.
@netlify

netlify Bot commented Apr 24, 2026

Copy link
Copy Markdown

Deploy Preview for taffy-docs ready!

Name Link
🔨 Latest commit b6a292f
🔍 Latest deploy log https://app.netlify.com/projects/taffy-docs/deploys/69ebb6e3c254f40008e0219c
😎 Deploy Preview https://deploy-preview-428--taffy-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['Semver-Major', 'Semver-Minor', 'Semver-Patch']

@JamoCA JamoCA closed this by deleting the head repository Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants