Skip to content

Fix lint errors and missing translations for Classic Editor task type feature#233

Merged
erseco merged 5 commits into
112-replace-quill-editor-with-wordpress-classic-editor-for-tasksfrom
copilot/sub-pr-183
Mar 8, 2026
Merged

Fix lint errors and missing translations for Classic Editor task type feature#233
erseco merged 5 commits into
112-replace-quill-editor-with-wordpress-classic-editor-for-tasksfrom
copilot/sub-pr-183

Conversation

Copilot AI commented Mar 8, 2026

Copy link
Copy Markdown
Contributor

CI was failing on two checks: make lint (3 PHPCS violations in class-decker-public.php) and make check-untranslated (4 Spanish strings missing for the task editor type settings introduced in the base branch).

Lint fixes (public/class-decker-public.php)

Removed double consecutive blank lines at three locations inside functions (lines 223, 297, 304) — all auto-fixable Generic.WhiteSpace.ScopeIndent-class violations flagged by PHPCS.

Missing translations (languages/decker-es_ES.po)

Added Spanish translations for strings introduced by the task editor type settings:

msgid msgstr
Task Editor Type Tipo de editor de tareas
Classic Editor Editor clásico
Quill Editor Editor Quill
Choose which editor to use for task descriptions… Elige qué editor usar para las descripciones de tareas…

Recompiled decker-es_ES.mo to match.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/OzzyCzech/icalparser/zipball/bc7a82b12455ae9b62ce8e7f2d0273e86c931ecc
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/PHPCSStandards/PHP_CodeSniffer/zipball/0ca86845ce43291e8f5692c7356fccf3bcf02bf4
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/PHPCSStandards/composer-installer/zipball/845eb62303d2ca9b289ef216356568ccc075ffd1
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/antecedent/patchwork/zipball/8b6b235f405af175259c8f56aea5fc23ab9f03ce
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/erseco/mime-mail-parser/zipball/0a5e00f949f3af88c81f409fb34946345b40d28b
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/hamcrest/hamcrest-php/zipball/f8b1c0173b22fa6ec77a81fe63e5b01eba7e6487
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/mockery/mockery/zipball/1f4efdd7d3beafe9807b08156dfcb176d18f1699
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/php-gettext/Languages/zipball/079d6f4842cbcbf5673a70d8e93169a684e7aadd
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/sebastianbergmann/cli-parser/zipball/2b56bea83a09de3ac06bb18b92f068e60cc6f50b
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/sebastianbergmann/code-unit/zipball/1fc9f64c0927627ef78ba436c9b17d967e68e120
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/sebastianbergmann/comparator/zipball/e4df00b9b3571187db2831ae9aada2c6efbd715d
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/sebastianbergmann/diff/zipball/ba01945089c3a293b01ba9badc29ad55b106b0bc
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/sebastianbergmann/environment/zipball/830c43a844f1f8d5b7a1f6d6076b784454d8b7ed
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/sebastianbergmann/exporter/zipball/14c6ba52f95a36c3d27c835d65efc7123c446e8c
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/sebastianbergmann/global-state/zipball/b6781316bdcd28260904e7cc18ec983d0d2ef4f6
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/sebastianbergmann/object-enumerator/zipball/5c9eeac41b290a3712d88851518825ad78f45c71
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/sebastianbergmann/object-reflector/zipball/b4f479ebdbf63ac605d183ece17d8d7fe49c15c7
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/sebastianbergmann/php-file-iterator/zipball/cf1c2e7c203ac650e352f4cc675a7021e7d1b3cf
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/sebastianbergmann/php-invoker/zipball/5a10147d0aaf65b58940a0b72f71c9ac0423cc67
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/sebastianbergmann/php-text-template/zipball/5da5f67fc95621df9ff4c4e5a84d6a8a2acf7c28
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/sebastianbergmann/php-timer/zipball/5a63ce20ed1b5bf577850e2c4e87f4aa902afbd2
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/sebastianbergmann/recursion-context/zipball/539c6691e0623af6dc6f9c20384c120f963465a0
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/sebastianbergmann/resource-operations/zipball/05d5692a7993ecccd56a03e40cd7e5b09b1d404e
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)
  • https://api.github.com/repos/sebastianbergmann/type/zipball/75e2c2a32f5e0b3aef905b9ed0b179b953b3d7c7
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/MhiOqE /usr/bin/composer install --quiet (http block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: erseco <1876752+erseco@users.noreply.github.com>
Copilot AI changed the title [WIP] Replace Quill editor with WordPress Classic Editor for tasks Merge main, fix missing media button in Classic Editor Mar 8, 2026
@erseco

erseco commented Mar 8, 2026

Copy link
Copy Markdown
Member

@copilot arregla los errores de lint y de traducciones faltantes

Copilot AI and others added 2 commits March 8, 2026 11:33
Co-authored-by: erseco <1876752+erseco@users.noreply.github.com>
Co-authored-by: erseco <1876752+erseco@users.noreply.github.com>

Copilot AI commented Mar 8, 2026

Copy link
Copy Markdown
Contributor Author

@copilot arregla los errores de lint y de traducciones faltantes

Fixed in commit 1fec69a. The CI was failing because 4 strings introduced by the task editor type feature had no Spanish translations in decker-es_ES.po. Added:

  • "Task Editor Type" → "Tipo de editor de tareas"
  • "Classic Editor" → "Editor clásico"
  • "Quill Editor" → "Editor Quill"
  • "Choose which editor to use for task descriptions..." → "Elige qué editor usar para las descripciones de tareas..."

Also recompiled the .mo binary. The msgattrib --untranslated check now returns 0 lines.

…ker-public.php

Co-authored-by: erseco <1876752+erseco@users.noreply.github.com>
Copilot AI changed the title Merge main, fix missing media button in Classic Editor Fix lint errors and missing translations for Classic Editor task type feature Mar 8, 2026
@erseco erseco marked this pull request as ready for review March 8, 2026 15:29
@erseco erseco merged commit 7ab6a9f into 112-replace-quill-editor-with-wordpress-classic-editor-for-tasks Mar 8, 2026
2 checks passed
@erseco erseco deleted the copilot/sub-pr-183 branch March 8, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants