Repository navigation
MAST: Fixes for remote test suite - #3688
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3688 +/- ##
==========================================
+ Coverage 73.86% 73.87% +0.01%
==========================================
Files 228 228
Lines 21475 21485 +10
==========================================
+ Hits 15863 15873 +10
Misses 5612 5612 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
snbianco
changed the title
snbianco
marked this pull request as ready for review
October 20, 2026 15:53
bsipocz
approved these changes
Oct 26, 2026
| def check_result(result, row, exp_values): | ||
| assert isinstance(result, Table) | ||
| for k, v in exp_values.items(): | ||
| print(result[row][k]) |
Member
|
Thank again, I much appreciate these fixes. As there are still a couple of failures after this PR I don't yet close #3688, but merge this as it for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick internal fixes for our remote test suite! Leaving out the Roman tests until our data is public, since right now we would need a token for the tests to pass.
Also fixing a bug in
ZcutClassthat was accidentally introduced in #3675