Skip to content

Remove astroquery.oac (OAC API retired) - #3687

Merged
bsipocz merged 3 commits into
astropy:mainfrom
guillochon:remove-oac
Oct 19, 2026
Merged

bsipocz merged 3 commits into
astropy:mainfrom
guillochon:remove-oac

Conversation

@guillochon

Copy link
Copy Markdown
Contributor

The Open Astronomy Catalogs API at https://api.astrocats.space is being retired, so this removes the astroquery.oac module, its tests, and its docs. It also adds a CHANGES entry.

Closes #3686

)

Co-authored-by: James Guillochon <jguillochon@esri.com>
@guillochon

Copy link
Copy Markdown
Contributor Author

@bsipocz could you review this when you have a moment? Thanks!

@giles

giles Bot commented Oct 19, 2026

Copy link
Copy Markdown

Hi 👋 and thank you for your contribution! 🙏

This pull request is being closed automatically - but don't worry, this is not the end, and we may re-open it.

For some background, we have recently started seeing a rapid increase in the number of pull requests opened. Some of these are from good-faith humans, but some of which are from autonomous LLM agents or humans using LLMs who do not have a genuine understanding of, or interest in, the project. We are therefore auto-closing pull requests from new contributors, but if you are a good-faith human, we want to make sure your pull request gets considered! So if you would like us to re-open your pull request so that it gets reviewed, you need to do two things:

  1. Add a comment here to explain why you need the changes here to be considered, as in how the bug or missing feature affects your work, or whether this is an issue you have encountered but does not affect you.

  2. Join the astropy slack using this invite link and head over to the #new-contributor-requests channel to introduce yourself and let us know about this pull request

The second step is important, as we may otherwise miss notifications about this pull request.

To be clear, our AI policy does allow the use of LLMs as part of contributions, but we need to see authentic engagement and understanding from humans making the contribution.

Notes for maintainers

If you know this is a genuine user and the PR is is compliance with the AI policy, you may re-open this straight away. After two successful merged pull requests, the user will be added to the allowlist and future PRs will no longer be closed automatically.

This user has not made any pull requests to this repository prior to this one.

In addition, here are some statistics on the user's activity on GitHub:

Last 24 hours Last 7 days
Pull requests opened 1 1
Issues opened 1 2

@giles giles Bot closed this Oct 19, 2026
@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.86%. Comparing base (117b82b) to head (da1bfdd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3687      +/-   ##
==========================================
- Coverage   73.88%   73.86%   -0.02%     
==========================================
  Files         230      228       -2     
  Lines       21620    21475     -145     
==========================================
- Hits        15974    15863     -111     
+ Misses       5646     5612      -34     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guillochon

Copy link
Copy Markdown
Contributor Author

Was not aware of the AI policy; this is a simple deletion PR though, adds no functionality.

@bsipocz bsipocz reopened this Oct 19, 2026
@bsipocz

bsipocz commented Oct 19, 2026

Copy link
Copy Markdown
Member

This is s genuine PR and was on my radar, thanks for opening it.

@guillochon

Copy link
Copy Markdown
Contributor Author

@bsipocz quoth my bot:

The OAC code was about 77% covered, compared with about 74% for the repo overall. Taking it out moves overall coverage from 73.88% to 73.86%, a 0.02% drop.

Not sure how you wish to resolve, but otherwise I think this is good to go.

@bsipocz

bsipocz commented Oct 19, 2026

Copy link
Copy Markdown
Member

Don't worry about it. I'll have a look tomorrow and merge it when I'm back at the keyboard

@bsipocz bsipocz added the oac label Oct 19, 2026
@bsipocz bsipocz added this to the 0.4.12 milestone Oct 19, 2026

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good. Thank you.
And thank you for all your work that you poured into OAC, even after you've left astronomy!

@bsipocz
bsipocz merged commit b6dafe9 into astropy:main Oct 19, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OAC API (api.astrocats.space) is being retired; please remove astroquery.oac

3 participants