Repository navigation
Remove astroquery.oac (OAC API retired) - #3687
Conversation
|
@bsipocz could you review this when you have a moment? Thanks! |
|
Hi 👋 and thank you for your contribution! 🙏 This pull request is being closed automatically - but don't worry, this is not the end, and we may re-open it. For some background, we have recently started seeing a rapid increase in the number of pull requests opened. Some of these are from good-faith humans, but some of which are from autonomous LLM agents or humans using LLMs who do not have a genuine understanding of, or interest in, the project. We are therefore auto-closing pull requests from new contributors, but if you are a good-faith human, we want to make sure your pull request gets considered! So if you would like us to re-open your pull request so that it gets reviewed, you need to do two things:
The second step is important, as we may otherwise miss notifications about this pull request. To be clear, our AI policy does allow the use of LLMs as part of contributions, but we need to see authentic engagement and understanding from humans making the contribution. Notes for maintainersIf you know this is a genuine user and the PR is is compliance with the AI policy, you may re-open this straight away. After two successful merged pull requests, the user will be added to the allowlist and future PRs will no longer be closed automatically. This user has not made any pull requests to this repository prior to this one. In addition, here are some statistics on the user's activity on GitHub:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3687 +/- ##
==========================================
- Coverage 73.88% 73.86% -0.02%
==========================================
Files 230 228 -2
Lines 21620 21475 -145
==========================================
- Hits 15974 15863 -111
+ Misses 5646 5612 -34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Was not aware of the AI policy; this is a simple deletion PR though, adds no functionality. |
|
This is s genuine PR and was on my radar, thanks for opening it. |
|
@bsipocz quoth my bot:
Not sure how you wish to resolve, but otherwise I think this is good to go. |
|
Don't worry about it. I'll have a look tomorrow and merge it when I'm back at the keyboard |
bsipocz
left a comment
There was a problem hiding this comment.
This all looks good. Thank you.
And thank you for all your work that you poured into OAC, even after you've left astronomy!
The Open Astronomy Catalogs API at https://api.astrocats.space is being retired, so this removes the
astroquery.oacmodule, its tests, and its docs. It also adds a CHANGES entry.Closes #3686