[KilimAnnejaro]

Adding a CDDIS source for GNSS data.

[giles]

Hi 👋 and thank you for your contribution! 🙏

This pull request is being closed automatically - but don't worry, this is not the end, and we may re-open it.

For some background, we have recently started seeing a rapid increase in the number of pull requests opened. Some of these are from good-faith humans, but some of which are from autonomous LLM agents or humans using LLMs who do not have a genuine understanding of, or interest in, the project. We are therefore auto-closing pull requests from new contributors, but if you are a good-faith human, we want to make sure your pull request gets considered! So if you would like us to re-open your pull request so that it gets reviewed, you need to do two things:

1. Add a comment here to explain why you need the changes here to be considered, as in how the bug or missing feature affects your work, or whether this is an issue you have encountered but does not affect you.

2. Join the astropy slack using this invite link and head over to the #new-contributor-requests channel to introduce yourself and let us know about this pull request

The second step is important, as we may otherwise miss notifications about this pull request.

To be clear, our AI policy does allow the use of LLMs as part of contributions, but we need to see authentic engagement and understanding from humans making the contribution.

Notes for maintainers

If you know this is a genuine user and the PR is is compliance with the AI policy, you may re-open this straight away. After two successful merged pull requests, the user will be added to the allowlist and future PRs will no longer be closed automatically.

This user has not made any pull requests to this repository prior to this one.

In addition, here are some statistics on the user's activity on GitHub:

	Last 24 hours	Last 7 days
Pull requests opened	1	1
Issues opened	0	0

[KilimAnnejaro]

I'm adding a data source for CDDIS data so I can get access to information about satellite positions. (This is for telescope aiming/personal experimentation.)

[keflavich]

can you say more about what cddis is and why it belongs in astroquery? are you affiliated with cddis at all or just doing this out of personal interest?

[KilimAnnejaro]

Just personal interest. This is a library I'm using for information about where satellites are.

[pllim]

Unless you can get someone from CDDIS to bless this, I am not sure if we should proceed.

[keflavich]

I'm not totally opposed to including it - but I do like the idea of reaching out to CDDIS staff to see if they want to be involved. @KilimAnnejaro would you be willing to do that?

[keflavich]

Thanks for reaching out @KilimAnnejaro !

Feedback from the team was:

No objection to astroquery offering a client for CDDIS data
Either access method is viable. EDL would require a person to first register with EDL before they could use. The CMR API is an option, but understand two limitations here:
    CMR might or might not have the granularity metadata to get you to the specific file you are looking for
    If CMR does find the granule, it will return a URL to the granule which would still require the use of an EDL account to get the file
A simple acknowledgment in the documentation/codebase of the use of CDDIS data is fine, along with citing the DOI of the actual datasets you are using. That would be greatly appreciated!
Regarding reviewing the module/being a POC: we wouldn't be able to actively maintain the codebase. We would get overwhelmed if we agreed to do that for all the things what use CDDIS (since there are many!). You are certainly welcome to:
    Give us more detail, title, and URL to the final GitHub lication and we will include it on a page of open source projects using CDDIS data
    Use our Helpdesk system (the system we are currently communicating on) to ask questions on implementation, help solving problems, etc.
    Provide us with an email address for whomever is currently maintaining your codebase so we can announce any possible changes that could affect your codebase.

I'm OK with including this code with the acknowledgement that maintenance will be a shared burden - it is possible that we will end up with slow responses from the CDDIS team, but they sound supportive enough.

@bsipocz I think we should have a tier like this: contributed by an interested third party with a supportive host that can't provide resources at the moment. A lot of the modules I maintain are this variety

[bsipocz]

OK, I'm happy with that response. You are right we have a few modules of a similar nature already.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.01%. Comparing base (c41a46a) to head (391d97e).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3685      +/-   ##
==========================================
+ Coverage   73.86%   74.01%   +0.14%     
==========================================
  Files         228      230       +2     
  Lines       21475    21598     +123     
==========================================
+ Hits        15863    15986     +123     
  Misses       5612     5612              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.