Add rubocop with a todo list#90
Merged
samsonjs merged 50 commits intoaserafin:masterfrom Jul 14, 2025
Merged
Conversation
pieterocp
reviewed
Jun 30, 2025
pieterocp
reviewed
Jun 30, 2025
Co-authored-by: Pieter Oliver <68863060+pieterocp@users.noreply.github.com>
Contributor
Zeroing is a noble goal, but merging this in and fixing issues one by one (e.g. gave the safe ones a go here: https://github.com/pieterocp/grape_logging/tree/add-all-todos ) should work, some will require a reasonable bit of restructuring and let us not let good be the enemy of perfect. |
Collaborator
Author
|
@pieterocp yep you're right, if you open up a PR against this branch we can merge this and at least have it running! Thanks for doing that legwork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll work through the todo list here before merging. Ideally we have rules set up and no todos left but we'll see how it goes.