Ensure UI Treats Labels Throughout As Display#48
Merged
davisadam10 merged 3 commits intodevfrom Apr 16, 2026
Merged
Conversation
Contexts in the FDL spec have no id field and label is optional. The viewer was using context labels as identifiers throughout the selection pipeline, which broke when a context had an empty label. The underlying C++ core API already identifies contexts by array index via fdl_doc_context_at(). Aligned the Python layer to match by using index-based selection across the viewer, imaging, and frameline generator packages. Labels are still used for display in dropdowns with the array index as fallback when empty.
Changed public API functions and get_fdl_components to accept context_index (int) instead of context_id (str). Labels are resolved to indices at test boundaries.
The settings class is named Settings not AppSettings. This caused the export image button to silently fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexts in the FDL spec have no id field and label is optional. The viewer was using context labels as identifiers throughout the selection pipeline, which broke when a context had an empty label.
The underlying C++ core API already identifies contexts by array index via fdl_doc_context_at(). Aligned the Python layer to match by using index-based selection across the viewer, imaging, and frameline generator packages. Labels are still used for display in dropdowns with the array index as fallback when empty.