Skip to content
This repository was archived by the owner on Apr 27, 2026. It is now read-only.
This repository was archived by the owner on Apr 27, 2026. It is now read-only.

Robust numeric op selection & FP detection #133

Description

@yuvimittal

Summary

Arithmetic/comparisons only check float32; double/half fall into integer ops so Add helpers is_fp(ty) and is_int(ty). Use them across + - * / < > <= >= == !=.

OS / Environment

-

Steps to Reproduce

File Upload (optional)

No response

Expected Results

Actual Results

-

IRx version

-

Code of Conduct

  • I agree to follow the Code of Conduct

Activity

  1. Eshaan-byte commented on Dec 5, 2025

    @Eshaan-byte
    Contributor

    Hi @yuvimittal! I'd like to work on this issue.

    I just completed #137 which fixed the float detection part by replacing FLOAT_TYPE checks with is_fp_type().

    For this issue, I can add the complementary is_int_type() helper function and ensure both helpers are used consistently across all arithmetic and comparison operators (+, -, *, /, <, >, <=, >=, ==, !=).

    Let me know if this is still needed or if my previous PR (#146) already addressed part of this! Happy to expand the work if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions