Skip to content

Added support for icons in submenu #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Allaoua9 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added support for icons in submenu #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions examples/.commands-full.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,17 @@
"icon": "utilities-terminal"
}
]
},
{
"title": "SSH Connections (With Icon)",
"type": "submenu",
"icon": "utilities-terminal",
"submenu": [
{
"title": "Connect to Server (SSH)",
"command": "gnome-terminal -- bash -c 'ssh root@10.144.1.2 -p 8022'"
}
]
}
]
}
6 changes: 5 additions & 1 deletion extension.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,11 @@ function populateMenuItems(menu, cmds, level) {
if (cmd.type === 'submenu' && level === 0) { // Stop submenu from being added after the first level
let submenu;
if (!cmd.submenu) { return; }
submenu = new PopupMenu.PopupSubMenuMenuItem(cmd.title);
const wantIcon = Boolean(cmd.icon)
submenu = new PopupMenu.PopupSubMenuMenuItem(cmd.title, wantIcon);
if (wantIcon) {
submenu.icon.icon_name = cmd.icon
}
populateMenuItems(submenu.menu, cmd.submenu, level + 1);
menu.addMenuItem(submenu);
return;
Expand Down