desktops: replace legacy machinery with armbian-config module_desktops

[igorpecovnik]

Summary

Replaces the entire build-time desktop machinery with armbian-config's YAML-driven module_desktops. Three commits:

1. build: clean up chroot environment + systemd disable noise

• chroot_custom / chroot_custom_long_running: add LC_ALL="C" LANG="C" LANGUAGE="" SUDO_USER="" (parity with chroot_sdcard/chroot_mount).
• disable_systemd_service_sdcard: use systemctl --root= to operate directly on the chroot filesystem instead of D-Bus. Output routed through display_alert at debug level — silent in normal builds, visible with DEBUG=yes.

2. desktops: delete legacy config tree + package builders

deleted	lines
config/desktop/ (~229 files)	~10,400
artifact-armbian-desktop.sh + artifact-armbian-bsp-desktop.sh	~215
armbian-desktop-deb.sh + armbian-bsp-desktop-deb.sh	~128
rootfs-desktop.sh	33

3. desktops: wire armbian-config module_desktops into rootfs creation

New variable: DESKTOP_TIER (minimal/mid/full) replaces DESKTOP_ENVIRONMENT_CONFIG_NAME + DESKTOP_APPGROUPS_SELECTED.

Interactive menu: clones configng via fetch_from_repo, queries the standalone Python parser for DE list + tier selection. Tier dialog notes that tiers can be upgraded/downgraded at runtime via armbian-config.

Desktop install in rootfs-create.sh (before cache — desktop packages are cached):

chroot_sdcard "SUDO_USER= DEBIAN_FRONTEND=noninteractive DIALOG=read \
  armbian-config --api module_desktops install \
  de=${DESKTOP_ENVIRONMENT} tier=${DESKTOP_TIER:-mid} mode=build"

Plymouth artifact moved to rootfs-create.sh (before cache, before desktop install).

DM disable in distro-agnostic.sh (after cache restore — runs on every build including cache hits).

Rootfs cache hash includes DESKTOP_TIER + configng desktops HEAD commit hash — any change to YAML/parser/module code invalidates the cache.

Cleanup across 17 files: artifacts registry, aggregation pipeline, Python tools, CLI commands, action.yml, templates, library-functions.sh source lines.

Net effect

	before	after
config files	~229	0 (YAML in configng)
library files	5	0
build variables	DESKTOP_ENVIRONMENT + CONFIG_NAME + APPGROUPS	DESKTOP_ENVIRONMENT + DESKTOP_TIER
package install	per-DE .deb via artifact system	armbian-config --api module_desktops install
DE list source	config/desktop/<release>/environments/	configng Python parser
desktop cached	yes (in rootfs-create)	yes (same position)

Test plan

• Interactive: DE + tier selection from configng JSON
• Non-interactive: BUILD_DESKTOP=yes DESKTOP_ENVIRONMENT=gnome DESKTOP_TIER=minimal
• Desktop image boots with working DE
• DMs disabled in rootfs, re-enabled by firstlogin
• Build log clean of locale / systemd disable warnings
• Cache hit: second build of same (board, release, DE, tier) reuses rootfs cache
• Cache invalidation: configng desktops commit change → new cache

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5610a400-75d7-48f1-b241-ad3902ec6a9c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch desktop-to-armbian-config

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details

{}