[DRAFT] EVM: optimize mkCodeOps, mkOpIxMap for concrete case - #1048
Draft
elopez wants to merge 2 commits into
Draft
[DRAFT] EVM: optimize mkCodeOps, mkOpIxMap for concrete case#1048elopez wants to merge 2 commits into
elopez wants to merge 2 commits into
Conversation
Add mkConcreteOps that works directly on ByteString without the intermediate [Expr Byte] list. The previous code did BS.unpack (allocates cons cell per byte) then LitByte <$> (wraps each in Expr) then maybeLitByteSimp (unwraps back to Word8) -- a pointless roundtrip. The new code indexes the ByteString directly and only creates [LitByte] for push data bytes that readOp actually needs.
Replace the accumulated monadic action chain (m >> write >> write >> ...) with direct ST writes during ByteString iteration. The old approach created O(n) closures for the >> chain; the new approach writes directly to the mutable vector with zero closure allocation.
elopez
changed the title
msooseth
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is showing >20% improvement on contract deployment heavy workloads like contractCreationMem but I need to give it more thought to see if it's truly equivalent, so I'm posting as draft.
Checklist