Upgrade Glide to v3#2802
Open
antonioribeiro wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades Glide from v2 to v3.
Glide v3 is now built on top of Intervention/Image 3, which is a pretty big deal. It brings a more modern architecture, better performance, and it can now use libvips as a driver, which is way faster than GD and Imagick for most operations.
The most interesting bits for Twill:
The whole codebase now uses strict typing and PHPStan v2, so it's generally more solid and less likely to break in weird ways.
What breaks
Older dependency versions are dropped, so minimum requirements go up. The
encodemanipulator is gone, replaced by the new encoder API.Is it stable?
They've already shipped three releases (3.0.0 → 3.0.1 → 3.1.0) with quick bug fixes, and the community is actively contributing. Looks good to me. 👍