Repository navigation
feat(cli): sync function interval in init, pull and push - #2003
Merged
Merged
Conversation
🟢 Tier S · Ready to mergeThe generated CLI now initializes, pulls, and pushes function intervals, including showing interval differences in the push change table; its Go SDK dependency is updated to v7.9.0. The validation workflow now uses Go 1.26.9. Latest changes: The newest commit updates the validation workflow's Go toolchain from 1.26.6 to 1.26.9.
📂 Walkthrough · 6
Reviewed the commits since |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functions can now run on an
interval(minutes) instead of a cronschedule(appwrite/appwrite#14231). This teaches the CLI about it:appwrite init functionwrites"interval": 0next to"schedule".appwrite pull functionskeepsintervalfrom the server.appwrite push functionssendsintervaland shows it in the change table.Push only sends keys present in the config, and the server keeps the stored interval when
intervalis omitted (appwrite/appwrite#14307). So a config written before this change no longer clears an interval set in the Console.Also bumps the CLI's Go SDK to v7.9.0, the release that adds
interval.Test Plan
TestFunctionWriteBodySendsIntervalOnlyWhenConfigured: a config withoutintervalsends none, and a configured one is sent.go mod tidy, gofmt,go build,go vetandgo test -race ./...all pass.Related: appwrite/appwrite#14170
Also bumps the validation Go toolchain from 1.26.6 to 1.26.9.
govulncheckwas failing thego (server)check onmain(GO-2026-6617, an HPACK race innet/http, fixed in go1.26.9).