Skip to content

fix(rust): cap tokio-util below 0.7.20 to keep the 1.83 MSRV - #2001

Merged
ChiragAgg5k merged 1 commit into
mainfrom
fix/rust-tokio-util-msrv
Oct 9, 2026
Merged

ChiragAgg5k merged 1 commit into
mainfrom
fix/rust-tokio-util-msrv

Conversation

@ChiragAgg5k

@ChiragAgg5k ChiragAgg5k commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

tokio-util 0.7.20 requires rustc 1.85, while generated Rust SDKs declare rust-version = "1.83" and publish with 1.83. It broke the sdk-for-rust 0.16.0 publish. Capping it alongside hyper-util keeps generated SDKs building on 1.83.

Same change in the SDK repo: appwrite/sdk-for-rust#32

Closes #2002

Related: #2002

@hansi-codes

hansi-codes Bot commented Oct 9, 2026

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

No defects found in the dependency constraint.

The Rust Cargo manifest template now constrains tokio-util to versions below 0.7.20. This keeps generated SDK dependency resolution compatible with the declared Rust 1.83 MSRV.

Verdict New comments Fixed Still open
✅ Approved 0 0 0
📂 Walkthrough · 1
File Change
templates/rust/Cargo.toml.twig Adds a tokio-util version constraint to the generated Rust dependency list.

Reviewed 778927f · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

@ChiragAgg5k
ChiragAgg5k merged commit f6aa4e8 into main Oct 9, 2026
60 of 61 checks passed
@ChiragAgg5k ChiragAgg5k self-assigned this Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cap tokio-util below 0.7.20 in Rust SDK template to keep 1.83 MSRV

1 participant