Repository navigation
[SDT-0002]: (SSC side) move ServiceContext from SSC to SDT implementation #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kukushechkin
merged 11 commits into
apple:main
from
kukushechkin:move-service-context-to-sdt
Oct 12, 2026
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1373c5d
move ServiceContext from SSC to SDT
kukushechkin 0e967ae
rename to ContextStorage
kukushechkin 5ec980c
Rename to Context
kukushechkin df6161a
Rename to TracingContext
kukushechkin 6d8ea48
update README
kukushechkin f778ef3
formatting fix
kukushechkin d06aa9f
fixup! formatting fix
kukushechkin 3fadc54
TODOLocation symbol should still be present
kukushechkin 1ec9b4a
Renamed to InstrumentationContext
kukushechkin 789833f
remove note annotations
kukushechkin 9929b2e
SDT 1.6.0
kukushechkin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift Service Context open source project | ||
| // | ||
| // Copyright (c) 2020-2026 Apple Inc. and the Swift Service Context project authors | ||
| // Licensed under Apache License v2.0 | ||
| // | ||
| // See LICENSE.txt for license information | ||
| // See CONTRIBUTORS.txt for the list of Swift Service Context project authors | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| // `ServiceContext`, `ServiceContextKey`, and `AnyServiceContextKey` now live in the | ||
| // `swift-distributed-tracing` package's `Instrumentation` module, renamed to `InstrumentationContext`, | ||
| // `InstrumentationContextKey`, and `AnyInstrumentationContextKey`. This module re-exports the module and | ||
| // declares its own, non-deprecated names so `import ServiceContextModule` keeps working unchanged, with no | ||
| // deprecation notice, for existing dependents of this package. `TODOLocation` kept its name, so this | ||
| // typealias just makes it reachable under this module too. | ||
| @_exported import Instrumentation | ||
|
|
||
| public typealias ServiceContext = Instrumentation.InstrumentationContext | ||
| public typealias ServiceContextKey = Instrumentation.InstrumentationContextKey | ||
| public typealias AnyServiceContextKey = Instrumentation.AnyInstrumentationContextKey | ||
| public typealias TODOLocation = Instrumentation.TODOLocation |
8 changes: 0 additions & 8 deletions
8
Sources/ServiceContextModule/Docs.docc/Reference/AnyServiceContextKey.md
This file was deleted.
Oops, something went wrong.
28 changes: 0 additions & 28 deletions
28
Sources/ServiceContextModule/Docs.docc/Reference/ServiceContext.md
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
Sources/ServiceContextModule/Docs.docc/Reference/ServiceContextKey.md
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be changed before merging. And this defines the sequence of merges — SDT first, SSC follows.