Repository navigation
Conversation
czechboy0
self-requested a review
October 10, 2026 20:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes apple/swift-openapi-generator#963
When returning a 406, right now we only return the code. Figuring out what code (and thus content type) we were actually trying to return requires the user to dig into the OpenAPI doc/server codebase more:
swift-openapi-runtime/Sources/OpenAPIRuntime/Errors/RuntimeError.swift
Line 168 in 49689c7
Modifications
Adds the error returned as the http body of the error response structued as a product details https://www.rfc-editor.org/rfc/rfc9457.html.
Along with human readable informations, it adds two extra fields
expectedandreceivedwhich contains machine readable information helping to figure out which accept header was received and which were expected.Result
{ "details":"Unexpected Accept header: text\/plain", "expected":"application\/json", "received":"text\/plain", "status":406, "title":"Unexpected Accept header", "type":"about:blank" }Test Plan
Added
testRuntimeError_withUnexpectedAcceptHeader_returnsProblemDetailstoTest_RuntimeError.