Skip to content

Allow Windows in CSPRNG, where SystemRandomNumberGenerator uses BCryptGenRandom #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
odrobnik wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

Allow Windows in CSPRNG, where SystemRandomNumberGenerator uses BCryptGenRandom #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Sources/NIOSSH/CSPRNG/CSPRNG.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,15 @@
/// for more details.
///
/// We feel confident that the `SystemRandomNumberGenerator` will remain a CSPRNG on all Apple platforms
/// and on Linux for the foreseeable future. This CSPRNG therefore wraps the `SystemRandomNumberGenerator`
/// and on Linux for the foreseeable future. On Windows the standard library documents and implements
/// `SystemRandomNumberGenerator` on top of `BCryptGenRandom` with `BCRYPT_USE_SYSTEM_PREFERRED_RNG`,
/// the system-preferred CSPRNG. This CSPRNG therefore wraps the `SystemRandomNumberGenerator`
/// on those platforms, and traps on all others.
struct CSPRNG: RandomNumberGenerator {
private var baseRNG: SystemRandomNumberGenerator

init() {
#if canImport(Darwin) || os(Linux) || os(Android)
#if canImport(Darwin) || os(Linux) || os(Android) || os(Windows)
self.baseRNG = SystemRandomNumberGenerator()
#else
fatalError("Platform does not have a supported CSPRNG")
Expand Down