Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
GeneralizedTime builds its fractional seconds from String(Double). Swift prints values below 0.0001 in scientific notation, so 0.00001 becomes "1e-05" and the encoder writes "-05" as the digits. The asserts that would catch this are stripped in release builds, so release emits an invalid encoding and debug aborts.
Only encoding is affected. The parser accepts digits only.
Modifications:
Expand scientific notation into plain digits in append(fractionalSeconds:). Replace the asserts with thrown errors. Add a test covering values from 0.0001 down to 1e-7 via both the initializer and the setter.
Result:
Small fractional seconds encode and round-trip correctly. The new test fails before this patch and passes after it.